Skip to content

MQE-1222: Selector Fails To Resolve Correctly in Action Group #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2018

Conversation

KevinBKozan
Copy link
Contributor

@KevinBKozan KevinBKozan commented Sep 21, 2018

Description

  • Added support for passing in data into arguments as {{mydata.value}}, solves use case where an actionGroup with the following:
    -- Argument name=data type=string
    -- Argument name=section
    -- Action with selector="{{section.elementWithParam(data)}}

  • In test
    -- data = {{mydata.value}}
    -- section = existingSection

  • Above now correctly fetches and resolves {{existingSection.elementWithParam(mydata.value)}}

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

- Added support for passing in data into arguments as `{{mydata.value}}`
- verification udpate for the above.
@coveralls
Copy link

coveralls commented Sep 21, 2018

Coverage Status

Coverage increased (+0.03%) to 57.494% when pulling 9844eda on MQE-1222 into 54a61f8 on develop.

@aljcalandra aljcalandra self-requested a review September 24, 2018 19:00
aljcalandra
aljcalandra previously approved these changes Sep 24, 2018
@KevinBKozan KevinBKozan merged commit de1ab89 into develop Sep 25, 2018
@KevinBKozan KevinBKozan deleted the MQE-1222 branch September 25, 2018 19:59
magento-devops-reposync-svc pushed a commit that referenced this pull request Nov 3, 2022
ACQE-3210 : Cannot Use WaitForElementClickable Action More Than Once …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants